-
Notifications
You must be signed in to change notification settings - Fork 130
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correctly include
poem
class on poem layout
BackstopJS is already paying off big time here, because without it I might not have caught this little subtle issue. While the `poem.html` layout used `poetry` as its container class, the CSS referenced a `poem` class (which fits with narrative and drama using their same file names as the container class). However, because `div.poem` did not exist, the margin set on the bottom of poems was never applied. That is now fixed, which is why the reference images are updated with this commit. (That said, the margins are collapsing in a way the original author of the CSS likely did not intend, but that's a fix for another day.) To preserve backward-compatibility, I have added the `poem` class to the existing `poetry` class in the poem template. I have also updated the CSS to account for the use of either `poem` or `poetry` as the container class names.
- Loading branch information
1 parent
ca208bf
commit a95ed62
Showing
12 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+88 Bytes
(100%)
...op_data/bitmaps_reference/ed_A_Julia_de_Burgos_Collapsed_0_document_0_micro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+104 Bytes
(100%)
...op_data/bitmaps_reference/ed_A_Julia_de_Burgos_Collapsed_0_document_1_small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+156 Bytes
(100%)
...data/bitmaps_reference/ed_A_Julia_de_Burgos_Collapsed_0_document_2_midrange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+151 Bytes
(100%)
...op_data/bitmaps_reference/ed_A_Julia_de_Burgos_Collapsed_0_document_3_large.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+215 Bytes
(100%)
...p_data/bitmaps_reference/ed_A_Julia_de_Burgos_Collapsed_0_document_4_larger.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+88 Bytes
(100%)
backstop_data/bitmaps_reference/ed_O_Captain_My_Captain_0_document_0_micro.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+95 Bytes
(100%)
backstop_data/bitmaps_reference/ed_O_Captain_My_Captain_0_document_1_small.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+150 Bytes
(100%)
backstop_data/bitmaps_reference/ed_O_Captain_My_Captain_0_document_2_midrange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+150 Bytes
(100%)
backstop_data/bitmaps_reference/ed_O_Captain_My_Captain_0_document_3_large.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+179 Bytes
(100%)
backstop_data/bitmaps_reference/ed_O_Captain_My_Captain_0_document_4_larger.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.