-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SAP as a provider #974
base: master
Are you sure you want to change the base?
Conversation
@mingrammer, any chance we can add this new provider to diagrams? |
Hi @ajmaradiaga, Thanks or the PR, I will check the changes. |
* Adding SAP provider configuration * Adding resources of provider SAP * Adding badge of SAP provider * Adding SAP provider in the documentation * Including additional SAP SaaS and ERP resources * Updating BTP icons
8371b47
to
588354d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The icons size must be maximum 256 as stated here:
https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md
Also you may think about adding alias for service name, if you only target German people that are used to version long name it's maybe ok. 😅
- Remove the extensions directory in erp.
- Resize the icons to max 256
- Add cleaner_sap in resource.py file
optional:
- Add alias
class SAPS4HANA(_Erp): | ||
_icon = "sap-s4hana.png" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the resources folder there's a sub directory 'extensions' that is not listed here, actually Diagrams support only until 2 levels so the data inside extensions are skipped.
I also noticed that there's already an extension directory with similar icons so if it's ok you can just delete the extensions directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forget this one, you need to implement a new cleaner not use another cleaner.
Each provider must have his own cleaner.
I really like the concept of Diagrams as Code and would like to include SAP as a provider in the diagrams library. Most of the diagrams that I do involve SAP services that are part of SAP's cloud offering - SAP BTP.
Without realising it... I've worked on this for quite some time...