feat(c4) Allow adding attributes. #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows in example adding hyperlinks to C4 diagrams, as requested on mingrammer#604. This also allows further customization for those elements.
|
@mingrammer I hope you like these changes, they are simple enough and have passed the development tests. IMO the code is a little bit more readable. I made these changes because I was documenting the infrastructure of a project and found that links work elsewhere but not in the C4 module. |
ajmaradiaga
pushed a commit
to ajmaradiaga/diagrams
that referenced
this pull request
Nov 8, 2023
This allows in example adding hyperlinks to C4 diagrams, as requested on mingrammer#604. This also allows further customization for those elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows in example adding hyperlinks to C4 diagrams, as requested on #604.
This also allows further customization for those elements.