Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources\aws png-optimization(loss less) #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pea-sys
Copy link

@pea-sys pea-sys commented Nov 6, 2022

Optimized png files in aws folder.
I think there is a user benefit.
In exchange, the size of this repository will increase, which may be a disadvantage for developers.

@mingrammer
Copy link
Owner

mingrammer commented Nov 8, 2022

It is a good improvement. @pea-sys I wonder which method did you use to optimize the images. Can we apply that method to other images?

@pea-sys
Copy link
Author

pea-sys commented Nov 8, 2022

@mingrammer
I used a simple tool.
https://github.com/pea-sys/ZopfliPng-GUI

I can optimize other images as well, do you mind if I use other PR?

@mingrammer
Copy link
Owner

mingrammer commented Nov 9, 2022

A couple of years ago, I opened an issue about optimizing the image size: #176. I wanted to add an optimization step to autogen process with a PNG optimizer. My first candidate for PNG optimizers was oxipng which is a multithreaded PNG optimizer written in Rust. (it is a CLI)

Your tool also looks good. But it is GUI based tool and runs on only a Windows environment. So I'd like to consider using the oxipng to automate the optimization processing while running autogen script. WDYT?

@pea-sys
Copy link
Author

pea-sys commented Nov 9, 2022

I created this tool for non-developers. I agree that it is not very convenient for developers.

It takes a long time to optimize all images.
It would seem that the method of selecting files to be optimized should also be optimized.

As an automatic optimization tool, this tool looks good at first glance.
https://github.com/calibreapp/image-actions

However, the tool accepts the push and then pushes the auto-optimization again, which conversely increases the repository size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants