Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Harbor as an on-prem registry #766

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

DR-dev-0714
Copy link
Contributor

Sorry for the dual commits, was having some local ENV issues:

  • Added dir resources/onprem/registry
  • Added Harbor Container Registry icon to resources/onprem/registry/harbor.png from https://github.com/cncf/artwork/blob/master/projects/harbor/icon/color/harbor-icon-color.png.
  • Ran convert resize command to resize original.
  • Ran autogen.sh via Docker.
  • Registry.py now exists in diagrams/onprem/ dir.
  • Docs/nodes/onprem.md auto-updated.
  • Tested that the Docusaurus-based website runs properly & has the expected updates for Harbor in the OnPrem nodes section.

Let me know if there's anything I missed or got wrong, I'm happy to fix it!

dryhn added 2 commits October 22, 2022 08:51
…icon resources/onprem/registry/harbor.png from https://github.com/cncf/artwork/blob/master/projects/harbor/icon/color/harbor-icon-color.png. Ran convert resize command to resize original. Ran autogen.sh via Docker. Registry.py now exists in diagrams/onprem/ dir. docs/nodes/onprem.md auto-updated.
…icon resources/onprem/registry/harbor.png from https://github.com/cncf/artwork/blob/master/projects/harbor/icon/color/harbor-icon-color.png. Ran convert resize command to resize original. Ran autogen.sh via Docker. Registry.py now exists in diagrams/onprem/ dir. docs/nodes/onprem.md auto-updated.
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer mingrammer merged commit 04e87fd into mingrammer:master Nov 8, 2022
ngruelaneo pushed a commit to aneoconsulting/diagrams that referenced this pull request Nov 25, 2022
…#766)

* Added dir resources/onprem/registry, added Harbor Container Registry icon resources/onprem/registry/harbor.png from https://github.com/cncf/artwork/blob/master/projects/harbor/icon/color/harbor-icon-color.png. Ran convert resize command to resize original. Ran autogen.sh via Docker. Registry.py now exists in diagrams/onprem/ dir. docs/nodes/onprem.md auto-updated.

Co-authored-by: dryhn <dryhn>
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this pull request Nov 8, 2023
…#766)

* Added dir resources/onprem/registry, added Harbor Container Registry icon resources/onprem/registry/harbor.png from https://github.com/cncf/artwork/blob/master/projects/harbor/icon/color/harbor-icon-color.png. Ran convert resize command to resize original. Ran autogen.sh via Docker. Registry.py now exists in diagrams/onprem/ dir. docs/nodes/onprem.md auto-updated.

Co-authored-by: dryhn <dryhn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants