-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): Replace IBM resources #655
base: master
Are you sure you want to change the base?
Conversation
@mingrammer this update would be really helpful to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions about alias and upper words.
_icon = "compose-janusgraph.png" | ||
|
||
|
||
class ComposeMysql(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (ComposeMySQL)
_icon = "compose-mysql.png" | ||
|
||
|
||
class ComposeRethinkdb(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (ComposeRethinkDB)
_icon = "compose-rethinkdb.png" | ||
|
||
|
||
class ComposeScylladb(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (ComposeScyllaDB)
_icon = "db2-warehouse.png" | ||
|
||
|
||
class Db2(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (DB2)
_icon = "db2.png" | ||
|
||
|
||
class Edb(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (EDB)
_icon = "etcd.png" | ||
|
||
|
||
class HyperProtectDbaas(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (HyperProtectDBaaS)
_icon = "portworx.png" | ||
|
||
|
||
class Postgresql(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (PostgreSQL)
_icon = "postgresql.png" | ||
|
||
|
||
class Rabbitmq(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: add an alias (RabbitMQ)
diagrams/ibm/database.py
Outdated
_icon = "redis.png" | ||
|
||
|
||
class SqlQuery(_Database): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add the sql to upper words list.
diagrams/ibm/devtools.py
Outdated
_icon = "alloy.png" | ||
|
||
|
||
class ApiGateway(_Devtools): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add the api to upper words list
fff5837
to
b433427
Compare
Is there a way to run the tests again on your side? Look like the same problem than the 805 PR with Ubuntu version. |
I brought back this PR with some fixes.
#517
Actual node resources don't display correctly strange as commented in this PR
#564
and so far the author didn't follow, so I push back my alternative.
I follow the official service catalog from here: https://cloud.ibm.com/catalog and adapt the category name with the diagrams one.