Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): Replace IBM resources #655

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gabriel-tessier
Copy link
Collaborator

I brought back this PR with some fixes.
#517

Actual node resources don't display correctly strange as commented in this PR
#564
and so far the author didn't follow, so I push back my alternative.
I follow the official service catalog from here: https://cloud.ibm.com/catalog and adapt the category name with the diagrams one.

@jordan-conklin
Copy link

@mingrammer this update would be really helpful to have

@mingrammer mingrammer added status/need-to-review Need to review comp/node Issue of node component area/provider/ibm IBM provider labels Nov 4, 2022
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions about alias and upper words.

_icon = "compose-janusgraph.png"


class ComposeMysql(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (ComposeMySQL)

_icon = "compose-mysql.png"


class ComposeRethinkdb(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (ComposeRethinkDB)

_icon = "compose-rethinkdb.png"


class ComposeScylladb(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (ComposeScyllaDB)

_icon = "db2-warehouse.png"


class Db2(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (DB2)

_icon = "db2.png"


class Edb(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (EDB)

_icon = "etcd.png"


class HyperProtectDbaas(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (HyperProtectDBaaS)

_icon = "portworx.png"


class Postgresql(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (PostgreSQL)

_icon = "postgresql.png"


class Rabbitmq(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: add an alias (RabbitMQ)

_icon = "redis.png"


class SqlQuery(_Database):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add the sql to upper words list.

_icon = "alloy.png"


class ApiGateway(_Devtools):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add the api to upper words list

@gabriel-tessier
Copy link
Collaborator Author

@mingrammer

Is there a way to run the tests again on your side? Look like the same problem than the 805 PR with Ubuntu version.
#805 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibm IBM provider comp/node Issue of node component status/need-to-review Need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants