Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer subprocess run over call #625

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Prefer subprocess run over call #625

merged 1 commit into from
Nov 4, 2022

Conversation

kkirsche
Copy link
Contributor

  1. Fix resource warning in the destructor
/Users/REDACTED/.asdf/installs/python/3.10.0/lib/python3.10/subprocess.py:1067: ResourceWarning: subprocess 46612 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback
  1. Use preferred, non-legacy API per https://docs.python.org/3/library/subprocess.html#subprocess.call
  2. Older call style no longer needed with Python 3.6+

@kkirsche
Prefer subprocess run over call
15cf2f4 
1. Fix resource warning in the destructor
```
/Users/REDACTED/.asdf/installs/python/3.10.0/lib/python3.10/subprocess.py:1067: ResourceWarning: subprocess 46612 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback

```

2. Use preferred, non-legacy API per https://docs.python.org/3/library/subprocess.html#subprocess.call
3. Older call style no longer needed with Python 3.6+
jurikolo added a commit to jurikolo/diagrams that referenced this pull request Jun 22, 2022
@jurikolo
Prefer subprocess run over call as suggested in mingrammer#625
b312c13
jurikolo added a commit to jurikolo/diagrams that referenced this pull request Sep 21, 2022
@jurikolo
Prefer subprocess run over call as suggested in mingrammer#625
8f34777
mingrammer
mingrammer approved these changes Nov 4, 2022
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@mingrammer mingrammer merged commit 55ca0c8 into mingrammer:master Nov 4, 2022
ngruelaneo pushed a commit to aneoconsulting/diagrams that referenced this pull request Nov 25, 2022
@kkirsche @ngruelaneo
refactor(scripts): prefer subprocess run over call (mingrammer#625)
edb7eae 
1. Fix resource warning in the destructor
```
/Users/REDACTED/.asdf/installs/python/3.10.0/lib/python3.10/subprocess.py:1067: ResourceWarning: subprocess 46612 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback

```

2. Use preferred, non-legacy API per https://docs.python.org/3/library/subprocess.html#subprocess.call
3. Older call style no longer needed with Python 3.6+
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this pull request Nov 8, 2023
@kkirsche @ajmaradiaga
refactor(scripts): prefer subprocess run over call (mingrammer#625)
9212878 
1. Fix resource warning in the destructor
```
/Users/REDACTED/.asdf/installs/python/3.10.0/lib/python3.10/subprocess.py:1067: ResourceWarning: subprocess 46612 is still running
  _warn("subprocess %s is still running" % self.pid,
ResourceWarning: Enable tracemalloc to get the object allocation traceback

```

2. Use preferred, non-legacy API per https://docs.python.org/3/library/subprocess.html#subprocess.call
3. Older call style no longer needed with Python 3.6+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkirsche @mingrammer