Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attributes on custom node #529

Closed
wants to merge 1 commit into from

Conversation

hackinvalid
Copy link

This fixes problem when trying to use pin, pos, etc with custom nodes

This fixes problem when trying to use `pin`, `pos`, etc with custom nodes
@hackinvalid hackinvalid changed the title Supporting attributes on custom node Support attributes on custom node May 10, 2021
Copy link

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I implemented something similar before finding this, and it seems to work well.

@pihart
Copy link

pihart commented Mar 26, 2022

Any reason why this hasn't been merged?

@markthompson94
Copy link

Could this be merged please? :)

@sabedevops
Copy link

Please merge this PR, it's very much needed.

@dvanbolt
Copy link

Please merge this

1 similar comment
@ThomasKat
Copy link

Please merge this

@mingrammer
Copy link
Owner

It is resolved by #437.

@mingrammer
Copy link
Owner

I close it!

@mingrammer mingrammer closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants