Added diagrams for IBM Provider #525
Conversation
|
@mingrammer Could you please review PR ? |
| @@ -0,0 +1,11 @@ | |||
| # This module is automatically generated by autogen.sh. DO NOT EDIT. | |||
There was a problem hiding this comment.
Aren't there any security nodes :) ?
There was a problem hiding this comment.
@mingrammer Please review. I added more diagrams.
There was a problem hiding this comment.
@mingrammer can you approve this week end ?
There was a problem hiding this comment.
The name of the files in network may not be correct, better to put lower case and "-" so the generated name will have camel case.
for ex:
class Directlink(_Network):
_icon = "DirectLink.png"
if the name of the file is direct-link.png the class generated will be DirectLink which look better.
Also just a global remarks there's no alias I think you can at least add FloatingIP after renaming the file floating-ip.png ! Same for all the class with VPN and VPC.
|
Review comments noted. I am working on it. |
|
@gabriel-tessier Please review now. I have corrected as per review comments. |
mingrammer
added
comp/node
|
I’ll review it tomorrow! |
|
@mingrammer @gabriel-tessier Can you review this weekend ? |
|
v0.20.0 is now released with IBM cloud support. |
|
Thankyou @mingrammer |
* 537: (33 commits) feat(provider): update OCI icons (mingrammer#537) docs: add IBM provider bump: up to version 0.20.0 feat(provider): added diagrams for IBM Provider (mingrammer#525) fix(readme): link to the GitPitch Cloud Diagram Markdown Widget (mingrammer#504) feat(node): update Azure icons (mingrammer#448) (mingrammer#494) feat(node): add Onprem Gitea (mingrammer#478) docs(all): update to main replica (mingrammer#477) docs(readme): fix typo (mingrammer#496) docs(readme): fix GitPitch website link feat(dev/docker): update to use latest stable python 3 (mingrammer#476) fix: wrong type check and indentations chore(deps-dev): bump pylint from 2.4.4 to 2.7.0 (mingrammer#470) docs(node): fix wrong class names bump: up to version 0.19.1 fix: wrong aliases and order bump: up to version 0.19.0 docs(edges): update edges example code chore(deps): bump jinja2 from 2.11.1 to 2.11.3 (mingrammer#456) docs: add contributors badge ...
Added diagrams for IBM Provider