Add icons to docs #499
Add icons to docs #499
Conversation
|
Hi, just for information there's already an issue about, you can check here: #78 The issue is pretty old but maybe there's some work in progress. |
|
thanks @gabriel-tessier, I must have missed that issue when I checked. @mingrammer, is this issue being worked on or could this PR help? Don't mind either way, but happy to make changes to this one if needed |
|
@mingrammer said they'd do work on #78 , but that was over a year ago. Given that there are so many duplicate issues raised for this, I believe it's a super valuable contribution. If it works, then we should just merge it. |
|
@mingrammer, does this PR look okay? There are now a couple of merge conflicts which I resolve if this can go in. This seems like a fairly frequently requested feature |
|
This is an AMAZING contribution. I love it ❤️ @lrjball Please resolve the conflicts, then I'll merge and deploy it. |
mingrammer
added
kind/docs
|
@mingrammer thanks 😃 all conflicts are resolved now, just had to rerun the autogen.sh as new icons had been added since I first made this |
|
There are many PRs that could be merged at any time. And I merged a PR, there was a conflict with this PR. I request the last update to resolve the conflict 🙏 Thank you! |
|
Okay no worries, should be resolved now |
|
@mingrammer This closes #78, #624, and #634 |
|
@lrjball I published the website :) Thank you so much. |
|
@bdsoha I'll close those. Thank you for addressing it. |
|
@mingrammer Sorry for the oversight, also #509. |
|
@bdsoha Thank you!! :D. I closed that. |
|
I announced this feature: #777. |
* Updated docs to include images of nodes * Updated docs to include images of nodes * Added icons to docs * Added black formatting * Added back png that removed due to incorrect naming convention * Revert yarn.lock changes
* Updated docs to include images of nodes * Updated docs to include images of nodes * Added icons to docs * Added black formatting * Added back png that removed due to incorrect naming convention * Revert yarn.lock changes
Thought it could be useful to have an image showing what the icon looks like in the docs. Also fixes #466
This is how the change looks:
I couldn't decide how to handle the white icons from OCI, so they are currently not visible against the white background, but they all have a black icon alternative next to them which is visible so that shouldn't be much of an issue. Can update this though if there any any suggestions for handling the white icons.