-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge attributes support #48
Conversation
As an improvement Edge could be replaced with dict in some cases, just to add some consistency with the original syntax ( node1 >> {'color': 'red'} >> node2 ), but it won't work with the group of nodes, regretfully ( nodes >> {'color': 'red'} >> node ). |
@ki11roy Is it possible to assign an icon to a node? thx! |
@pchaganti take a look at examples with Custom Nodes, this feature is about edges only. |
Awesome. Great works! I'll test it with some diagrams for checking backward compatibility. And could you please add a practical example diagram in the examples page? |
Added some examples and additional parameter "style" (i.e. dotted, dashed, bold, solid). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for adding a great feature. I really appreciate it :)
First, I would like to say thank you for such a handy tool, because I personally hate to draw diagrams by hand.
This PR adds support for Edges, colors and labels in particular and some other features like circular references and so on. Also, I have slightly changed tests to use folders instead of files in some cases. Just comment tear down to keep the folders with images.
Examples of usage could be seen in the tests, for example: