Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node.id to be specified and not automatically generated #422

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

vanife
Copy link
Contributor

@vanife vanife commented Dec 29, 2020

This is for readability of the generated dot.file, which helps debugging as well.

@mingrammer mingrammer added comp/node Issue of node component kind/feature New feature or request labels Aug 21, 2021
@vringar
Copy link

vringar commented Aug 9, 2022

Is there anything preventing this from getting merged?

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingrammer mingrammer merged commit 3c72e76 into mingrammer:master Nov 4, 2022
ngruelaneo pushed a commit to aneoconsulting/diagrams that referenced this pull request Nov 25, 2022
…mingrammer#422)

* allow node.id to be specified and not generated

* typing suport for context functions

Co-authored-by: Ivan Melnychuk <[email protected]>
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this pull request Nov 8, 2023
…mingrammer#422)

* allow node.id to be specified and not generated

* typing suport for context functions

Co-authored-by: Ivan Melnychuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/node Issue of node component kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants