Add AWS resources #381
Merged
Add AWS resources #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semnil
force-pushed
the
add-aws-resources
branch
from
4078deb to
8db916c
Compare
semnil
commented
Nov 28, 2020
docs/nodes/aws.md
Outdated
Comment on lines
439
to
441
| - **diagrams.aws.network.ElbApplicationLoadBalancer** | ||
| - **diagrams.aws.network.ElbClassicLoadBalancer** | ||
| - **diagrams.aws.network.ElbNetworkLoadBalancer** |
There was a problem hiding this comment.
Perhaps removing the "Elb" prefix might be more user-friendly. 🤔
|
This adds a lot of value.. @mingrammer - Thoughts? |
mingrammer
reviewed
Jan 28, 2021
mingrammer
added
area/provider/aws
|
@semnil @wolfspyre Sorry for the late review :( I left a review comment. |
semnil
force-pushed
the
add-aws-resources
branch
from
0216e51 to
d054783
Compare
|
@mingrammer Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the results of this wonderful project a lot. Thank you. 😄
Add AWS resources (from the AWS architecture icons).
I may have added too many at once. 😅
If the file names aren't right, I'll fix it!
Closes #272