Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: GCP monitoring #343

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Add: GCP monitoring #343

merged 1 commit into from
Jan 27, 2021

Conversation

pyaillet
Copy link
Contributor

@pyaillet pyaillet commented Oct 8, 2020

Add an icon for GCP Monitoring solving #315

@pyaillet pyaillet changed the title feat: ✨ add gcp monitoring Add: GCP monitoring Oct 8, 2020
@tanjinP
Copy link

tanjinP commented Oct 28, 2020

@pyaillet instead of management do you think it's better to call it operations? - as per their documentation

@pyaillet
Copy link
Contributor Author

@pyaillet instead of management do you think it's better to call it operations? - as per their documentation

✅ Done !
Thanks for the review :)

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer
Copy link
Owner

@tanjinP Good point. Thanks for the review.

@mingrammer mingrammer merged commit df061cd into mingrammer:master Jan 27, 2021
gabriel-tessier pushed a commit to bkmeneguello/diagrams that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants