Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Litmus Chaos and Chaos Mess for chaos engineering #297

Merged
merged 6 commits into from
Oct 7, 2020

Conversation

nlamirault
Copy link
Contributor

Signed-off-by: Nicolas Lamirault [email protected]

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tools are for k8s. Right?

@nlamirault
Copy link
Contributor Author

nlamirault commented Oct 3, 2020

Yes @mingrammer
i was hesitant to put chaos in kubernetes actually.

@mingrammer
Copy link
Owner

mingrammer commented Oct 3, 2020

Hm, which do you think is better for these among onprem.chaos, k8s.ecosystem, or new cloudnative.chaos?

@nlamirault
Copy link
Contributor Author

nlamirault commented Oct 3, 2020

@mingrammer cloudnative.chaos 👍

@wolfspyre
Copy link
Contributor

I don't really know what I'm talking about here, so take my input well salted; but I personally think chaos might fit better as a primary resource with the specific tools within the space contained within it. Alternatively, it might fit better as a branch off of generic IE: generic.chaos.obnoxiousPRCommenter ;)

@mingrammer
Copy link
Owner

mingrammer commented Oct 5, 2020

@wolfspyre But these tools are for k8s and cloud-native applications. So I think cloudnative.chaos or k8s.ecosystem might be better for these.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-run the autogen to add cloudnative provider.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Copy link
Contributor Author

@mingrammer done.

@mingrammer
Copy link
Owner

@nlamirault Ah, since the cloudnative is a new provider, you need to do some extra work to support a new provider.

You should add the cloudnative to config.py, and add the some functions for cloudnative to resource.py.

Sorry for that there is no guideline for adding a new provider, I'll add a guideline for this.

@mingrammer
Copy link
Owner

@nlamirault Wait .. hmm we need to re-discuss about which provider is suitable for these tools. Jaeger is also cloud native projet, but it could be under the onprem provider, so I think cloudnative provider could be getting a little vague. wdyt?

@nlamirault
Copy link
Contributor Author

@mingrammer LitmusChaos and ChaosMesh are for Kubernetes. So, why not k8s.chaos like k8s.ecosystem is for Kubernetes tools.

@mingrammer
Copy link
Owner

@nlamirault k8s.chaos sounds good to me.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Copy link
Contributor Author

@mingrammer Done.

Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer mingrammer merged commit 3a6a18d into mingrammer:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants