Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Buzfeed SSO and Oauth2 Proxy #296

Merged
merged 2 commits into from
Oct 3, 2020
Merged

Add: Buzfeed SSO and Oauth2 Proxy #296

merged 2 commits into from
Oct 3, 2020

Conversation

nlamirault
Copy link
Contributor

Signed-off-by: Nicolas Lamirault [email protected]

@nlamirault
Add: Buzfeed SSO and Oauth2 Proxy
917adc2 
Signed-off-by: Nicolas Lamirault <[email protected]>
mingrammer
mingrammer reviewed Sep 27, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest onprem.auth or onprem.identity category for these services. Reference the saas.identity category

@nlamirault
Copy link
Contributor Author

nlamirault commented Sep 27, 2020 •
edited
Loading

@mingrammer i move into onprem.auth. I had chosen network to put these services with Pomerium.
Why not move Pomerium into onprem.auth ?

@mingrammer
Copy link
Owner

I think pomerium seems fit to the network rather than auth.

This is a description of pomerium: Pomerium is an identity-aware proxy that enables secure access to internal....

@nlamirault
Copy link
Contributor Author

@mingrammer 👍

mingrammer
mingrammer approved these changes Oct 3, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@mingrammer mingrammer merged commit 85d03e3 into mingrammer:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlamirault @mingrammer