Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConcourseCI #198

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Add ConcourseCI #198

merged 5 commits into from
Jun 17, 2020

Conversation

nvictor
Copy link
Contributor

@nvictor nvictor commented Jun 11, 2020

  • Adds ConcourseCI to the onprem.ci nodes.
  • Updates documentation.

mingrammer
mingrammer requested changes Jun 13, 2020
View reviewed changes
diagrams/onprem/ci.py Show resolved Hide resolved
@nvictor
Copy link
Contributor Author

nvictor commented Jun 16, 2020

Hey, so I regenerated the changes using autogen.sh. I have also resized using ffmpeg.

@nvictor nvictor requested a review from mingrammer June 17, 2020 01:15
mingrammer
mingrammer approved these changes Jun 17, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer mingrammer merged commit a0891aa into mingrammer:master Jun 17, 2020
@nvictor nvictor deleted the add_concourse_ci branch June 18, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvictor @mingrammer