Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alibaba cloud resources #19

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Conversation

Prodesire
Copy link
Contributor

@Prodesire Prodesire commented Feb 15, 2020

This project is pretty awesome! But it is a bit regrettable that it lacks the resources of Alibaba Cloud.

This PR has added a number of Alibaba Cloud resources. Hope it will help.

@Prodesire Prodesire requested a review from mingrammer February 16, 2020 04:22
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!! And all the conventions are perfect.

Thanks for your contribution :) I'll release a new version soon.

@mingrammer mingrammer merged commit 1f5dbb2 into mingrammer:master Feb 16, 2020
@mingrammer
Copy link
Owner

mingrammer commented Feb 16, 2020

diagrams v0.4.0 is now released with alibaba cloud support.

Thank you again :)

@Prodesire
Copy link
Contributor Author

Wonderful !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants