Added option to preserve dot file #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingrammer
reviewed
May 31, 2020
| @@ -487,7 +490,8 @@ def append(self, other: Union[List["Node"], List["Edge"]], forward=None, reverse | |||
| self._attrs = o.attrs.copy() | |||
| result.append(o) | |||
| else: | |||
| result.append(Edge(o, forward=forward, reverse=reverse, **self._attrs)) | |||
| result.append( | |||
There was a problem hiding this comment.
Auto formatter must have done that. It doesn't improve readability much though, I will revert it.
| @@ -83,6 +83,7 @@ def __init__( | |||
| graph_attr: dict = {}, | |||
| node_attr: dict = {}, | |||
| edge_attr: dict = {}, | |||
| preserve_graphviz_file: bool = False | |||
| @@ -138,7 +140,8 @@ def __enter__(self): | |||
| def __exit__(self, exc_type, exc_value, traceback): | |||
| self.render() | |||
| # Remove the graphviz file leaving only the image. | |||
| os.remove(self.filename) | |||
| if (not self.preserve_graphviz_file): | |||
There was a problem hiding this comment.
The parentheses are not needed.
There was a problem hiding this comment.
That's my javascript coming out... I'll put it back
|
Does |
|
No, but I can arrange for that. |
|
How about when |
|
IMO, |
|
Any changes this gets merged soonish? |
This was referenced Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will preserve the dot file generated for later use.
I could also refactor this so that dot file is preserved when
outformat="dot"This is a non-breaking change because
preserve_graphviz_fileis False by default.