Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZuulCI as onprem CI resource #145

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

y2kenny
Copy link
Contributor

@y2kenny y2kenny commented May 16, 2020

Zuul is an open source program that drives continuous integration,
delivery, and deployment systems with a focus on project gating and
interrelated projects.

https://zuul-ci.org/

@mingrammer
Copy link
Owner

It doesn't seem to have been generated via autogen.sh. Please run the autogen.sh to add the new node class.

@mingrammer mingrammer added area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request labels May 17, 2020
@y2kenny
Copy link
Contributor Author

y2kenny commented May 19, 2020

It doesn't seem to have been generated via autogen.sh. Please run the autogen.sh to add the new node class.

I tried running that but it pretty much touches every file in the repository (removing empty lines and other unrelated artifacts.) Are you ok with that?

@y2kenny
Copy link
Contributor Author

y2kenny commented May 19, 2020

Actually... not every files but a few that don't look relevant. Should I just pick and choose?

@mingrammer
Copy link
Owner

Don’t mind the changes. That might be due to unpredictable order of dict.

@mingrammer
Copy link
Owner

Could you please add ZuulCI alias in config.py?

Zuul is an open source program that drives continuous integration,
delivery, and deployment systems with a focus on project gating and
interrelated projects.

https://zuul-ci.org/
@y2kenny
Copy link
Contributor Author

y2kenny commented May 24, 2020

Could you please add ZuulCI alias in config.py?

Ok done.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you :)

@mingrammer mingrammer merged commit c17bf1e into mingrammer:master May 25, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...

Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants