Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextvars to pyproject.toml #13

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Add contextvars to pyproject.toml #13

merged 2 commits into from
Feb 13, 2020

Conversation

rajat404
Copy link
Contributor

Fixes issue raised in #12

P.S: Thanks for building this lib. I always wanted something like this 😍

@mingrammer
Copy link
Owner

mingrammer commented Feb 12, 2020

Python 3.7 or later has builtin contextvars library. The contextvars package is only needed for python 3.6.

So, please add the version restriction for contextvars library like this:

contextvars = { version = "^2.4", python = "~3.6" }

Reference: https://python-poetry.org/docs/versions/#python-restricted-dependencies

@rajat404
Copy link
Contributor Author

Done. Please check 🖖

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll release a new version.

@mingrammer mingrammer merged commit 27f6e3a into mingrammer:master Feb 13, 2020
@mingrammer
Copy link
Owner

diagrams v0.2.4 is now released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants