Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DynamoDB Streams icon #1074

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

kakakakakku
Copy link
Contributor

Hi 😀 Thank you for providing such an awesome tool!

I wanted to use the DynamoDB Streams icon, but I couldn't find it. The motivation for this pull request is to add the DynamoDB Streams icon.

Note 🗒️

AWS provides official icon sets, and the database category icons have already been redesigned to a pink-like color.
https://aws.amazon.com/architecture/icons/

Res_Amazon-DynamoDB_Stream_48

However, the existing database category icons in this tool use an older version. To maintain consistency, I aligned the design with the existing icons. I found the old design on this website (note: the old design is no longer officially provided).
https://cloud-icons.onemodel.app/aws/resource_icons/res_database/res_amazon_dynamodb_stream

Check ✔️

I checked with my sample code.

with Diagram('', filename='./sample', show=False):
    table = DynamodbTable('DynamodbTable')
    item = DynamodbItem('DynamodbItem')
    streams = DynamodbStreams('DynamodbStreams')

image

Could you please review? Thanks a lot 👍

@tvqphuoc01 tvqphuoc01 merged commit 9740dce into mingrammer:master Nov 27, 2024
8 checks passed
@tvqphuoc01
Copy link
Collaborator

@kakakakakku merged thanks for your contribution 🚀

@kakakakakku kakakakakku deleted the dynamodb-streams branch November 27, 2024 08:52
@kakakakakku
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants