Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagrams.onprem.network.Mikrotik #1058

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

nobiit
Copy link
Contributor

@nobiit nobiit commented Nov 17, 2024

Added Mikrotik as it is also quite popular
Website: https://mikrotik.com/

@nobiit
Copy link
Contributor Author

nobiit commented Nov 17, 2024

Example

image

from diagrams import Diagram
from diagrams.onprem.network import Pfsense, Mikrotik
from diagrams.onprem.proxmox import ProxmoxVE

with Diagram('Network', show=False):
    nfg1 = Pfsense('nfg1')
    nrg1 = Mikrotik('nrg1')

    nfg1 >> nrg1 >> [ProxmoxVE('v1'), ProxmoxVE('v2'), ProxmoxVE('v3')]

@gabriel-tessier
Copy link
Collaborator

@nobiit
Thanks for the PR,

The logo you submitted is different than the one on their website.
There's a list and instructions on their page: https://mikrotik.com/logo

Also check the instructions about the icon size here: about the https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

@nobiit nobiit force-pushed the features/add_mikrotik branch from 7eecf57 to 622f988 Compare November 18, 2024 03:47
@nobiit
Copy link
Contributor Author

nobiit commented Nov 18, 2024

network

@nobiit
Copy link
Contributor Author

nobiit commented Nov 18, 2024

I changed the logo to exactly 256px, thanks for the advice. @gabriel-tessier Can you check it for me?

@nobiit nobiit force-pushed the features/add_mikrotik branch from 622f988 to 1e41e26 Compare November 18, 2024 04:11
@gabriel-tessier gabriel-tessier merged commit f7abcd0 into mingrammer:master Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants