Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the backward compatibility for type hint #1052

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mingrammer
Copy link
Owner

@mingrammer mingrammer commented Nov 7, 2024

Hi @liancheng @gabriel-tessier . The | for type hint does not work for < Python 3.9. I fixed it with the Union function.

@mingrammer
Copy link
Owner Author

This is a hotfix issue, so I should merge it immediately. Check later, please.

@mingrammer mingrammer merged commit c2c24c6 into master Nov 7, 2024
7 checks passed
@mingrammer mingrammer deleted the keep-backward-compatability branch November 7, 2024 02:18
@mingrammer
Copy link
Owner Author

cc @filipeaaoliveira, @tvqphuoc01

@gabriel-tessier
Copy link
Collaborator

@mingrammer
Do we need to support version < 3.9?

3.8 support end 1 month ago:
https://endoflife.date/python

The unit tests run for Python 3.9 and greater.
https://github.com/mingrammer/diagrams/actions/runs/11715386813

My opinion is to stick with the lower version of the tests 3.9.

Note for later update the Readme.
"It requires Python 3.7 or higher, check your Python version first."

@tvqphuoc01
Copy link
Collaborator

tvqphuoc01 commented Nov 18, 2024

agree with @gabriel-tessier our pipeline is only scan code with Python version higher 3.8 so I think we don't need to support v3.8

@mingrammer
Copy link
Owner Author

mingrammer commented Nov 20, 2024

Agree with all of you. I didn't check the EOL of 3.8.

I'll update the badge and requirements in the readme. Thank you for checking it.

@mingrammer
Copy link
Owner Author

I made a PR: #1064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants