-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. #1038
Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. #1038
Conversation
Thank you for the PR, You can read all the details about here: about the https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md |
b191513
to
a621f92
Compare
Dear @gabriel-tessier, First, I appreciate you taking the time to review my contribution. I’ve implemented your recommendations: I updated the image and ran the autogen script. However, it generated a few additional changes. Should I remove these, or would it be better to add a new commit for them? Or should I leave them as is? Could you please review it again when you have a moment? Thank you very much! |
@laiminhtrung1997 |
a621f92
to
57f392b
Compare
I removed unrelated files. Please have a look again. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.