Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Text on "Flask" icon overlaps label #794

Closed
ewinnington opened this issue Nov 11, 2022 · 4 comments
Closed

bug: Text on "Flask" icon overlaps label #794

ewinnington opened this issue Nov 11, 2022 · 4 comments

Comments

@ewinnington
Copy link
Contributor

The Flask icon, when used in a diagram, has the text "Flask", which overlaps the label.

I guess it is because the icon is too tall (256x382 px).

deployed_jobs

from diagrams import Diagram
from diagrams.programming.framework import Flask
from diagrams.onprem.client import Users
from diagrams.programming.language import Python
from diagrams.onprem.workflow import Airflow

with Diagram("Deployed jobs"):
    Users("End user") >> Flask("website")
    Airflow("Task") >> Python("Import Function")
@ewinnington
Copy link
Contributor Author

flask

Added a "naked" 256x256 Flask icon without the text.

@leirons
Copy link

leirons commented Nov 12, 2022

Tested and seems fine with this icon, can you create pull request?

ewinnington added a commit to ewinnington/diagrams that referenced this issue Nov 12, 2022
@ewinnington
fix bug: Text on Flask icon overlaps label mingrammer#794
48e8e6d
ewinnington added a commit to ewinnington/diagrams that referenced this issue Nov 12, 2022
@ewinnington
fix bug: Text on Flask icon overlaps label mingrammer#794
6a21d51
@ewinnington ewinnington mentioned this issue Nov 12, 2022
Merged
mingrammer pushed a commit that referenced this issue Jan 8, 2023
@ewinnington
fix bug: Text on Flask icon overlaps label #794 (#795)
2851d8d 
* fix bug: Text on Flask icon overlaps label #794

* added second image that I forgot
@bdsoha
Copy link
Contributor

bdsoha commented Jan 8, 2023

@mingrammer @ewinnington This can be closed.

@mingrammer
Copy link
Owner

I close it.

ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this issue Nov 8, 2023
@ewinnington @ajmaradiaga
fix bug: Text on Flask icon overlaps label mingrammer#794 (mingrammer…
ea6f823 
…#795)

* fix bug: Text on Flask icon overlaps label mingrammer#794

* added second image that I forgot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ewinnington @bdsoha @mingrammer @leirons