Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian support for generic.os class ? #549

Closed
seboss666 opened this issue Jun 27, 2021 · 3 comments
Closed

Debian support for generic.os class ? #549

seboss666 opened this issue Jun 27, 2021 · 3 comments

Comments

@seboss666
Copy link

seboss666 commented Jun 27, 2021 •
edited
Loading

Hello,

I'm pretty surprised not to find Debian in the supported generic.os section : https://diagrams.mingrammer.com/docs/nodes/generic#genericos

Thought it was a mistake so I went to the os.py version, and managed to add it myself (yes, before reading the contributing guide, so it was a little rough :D)

As I found no existing/closed PR or any existing/closed issue regarding this, is there something already planned to add it, or is there something blocking (like licenses on logos, yes even with Debian) ?
@gabriel-tessier
Copy link
Collaborator

@seboss666
You can always create a PR, for licenses on logo I think you can easily find one Creative Common icon.

managed to add it myself <--- just for information you can use custom and add any icon for yourself. https://diagrams.mingrammer.com/docs/nodes/custom

But for Debian I think a PR will be more useful!

gabriel-tessier added a commit to gabriel-tessier/diagrams that referenced this issue Jul 23, 2021
@gabriel-tessier
feat(node): add Generic OS Debian (mingrammer#549)
00cf325
@gabriel-tessier gabriel-tessier mentioned this issue Jul 23, 2021
Merged
haad added a commit to haad/diagrams that referenced this issue May 12, 2022
@haad
Merge branch '549' into terraform-provider
982383b 
* 549:
  feat(node): add Generic OS Debian (mingrammer#549)
haad added a commit to haad/diagrams that referenced this issue May 12, 2022
@haad
Merge branch 'terraform-provider'
30547dd 
* terraform-provider:
  update raspbian.png for size
  Updat Azure nodes to Azure_Public_Service_Icons_V4
  Prefer subprocess run over call
  Added raspbian.png for Raspberry Pis.
  Add Raspberry Pi logo for describing RPis.
  feat(provider): update OCI icons (mingrammer#537)
  docs(website): update text on top page.
  feat(node): add Generic OS Debian (mingrammer#549)
  Add k8s cluster / kubernetes icons
  Add ravendb resource node
  👌 IMPROVE: HashiCorp Icons
  📦 NEW: Add remaining HashiCorp Icons
  Adds Terraform icons support
  add tencentcloud
mingrammer pushed a commit that referenced this issue Nov 7, 2022
@gabriel-tessier
feat(node): add Generic OS Debian (#549) (#570)
a19705c 
* feat(node): add Generic OS Debian (#549)

* [Fix] picture size
@bdsoha
Copy link
Contributor

bdsoha commented Nov 10, 2022

@mingrammer @seboss666 This has been added in #570 and can be closed.

@seboss666
Copy link
Author

Thanks for noticing :)

ngruelaneo pushed a commit to aneoconsulting/diagrams that referenced this issue Nov 25, 2022
@gabriel-tessier @ngruelaneo
feat(node): add Generic OS Debian (mingrammer#549) (mingrammer#570)
d6c8db1 
* feat(node): add Generic OS Debian (mingrammer#549)

* [Fix] picture size
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this issue Nov 8, 2023
@gabriel-tessier @ajmaradiaga
feat(node): add Generic OS Debian (mingrammer#549) (mingrammer#570)
50d023f 
* feat(node): add Generic OS Debian (mingrammer#549)

* [Fix] picture size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabriel-tessier @seboss666 @bdsoha