Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any reason why there's no customization available for Node like Edge? #127

Closed
ElvinEfendi opened this issue May 9, 2020 · 2 comments
Closed

Any reason why there's no customization available for Node like Edge? #127

ElvinEfendi opened this issue May 9, 2020 · 2 comments
Labels
comp/node Issue of node component kind/feature New feature or request

Comments

@ElvinEfendi
Copy link

Looking at the source code, there's a way to customize Edge using attrs argument. Whereas for Node I can set only a label:

diagrams/diagrams/__init__.py

Line 270 in 353e7eb

def __init__(self, label: str = ""):
.

Any fundamental reason why is it not exposed? I'd be happy to make a PR request addressing this.
@mingrammer
Copy link
Owner

mingrammer commented May 9, 2020 •
edited
Loading

There is no big reason. Yes, you can make PR for adding that.

@mingrammer mingrammer added comp/node Issue of node component kind/feature New feature or request labels May 9, 2020
sulewicz pushed a commit to sulewicz/diagrams that referenced this issue May 18, 2020
Add attribute customization option for Nodes (mingrammer#127)
94bd2cd
@sulewicz sulewicz mentioned this issue May 18, 2020
Merged
mingrammer pushed a commit that referenced this issue May 20, 2020
@sulewicz
Add attribute customization option for Nodes (#127) (#151)
af85c15 
Co-authored-by: Szymon Ulewicz <[email protected]>
@ElvinEfendi
Copy link
Author

Thanks to @sulewicz this has now been addressed in #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp/node Issue of node component kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElvinEfendi @mingrammer