Skip to content

Commit

Permalink
fix(diagrams): Set a dummy filename to prevent raise error when both … (
Browse files Browse the repository at this point in the history
#240)

* fix(diagrams): Set a dummy filename to prevent raise error when both name and filename are not provided(#203)

* Update __init__.py

Update default name to "diagrams_image"

* Update test_diagram.py

Update unit test to reflect the file name change.
  • Loading branch information
gabriel-tessier authored Jul 23, 2020
1 parent abc49cf commit f260556
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
5 changes: 3 additions & 2 deletions diagrams/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@ def __init__(
:param edge_attr: Provide edge_attr dot config attributes.
"""
self.name = name

if not filename:
if not name and not filename:
filename = "diagrams_image"
elif not filename:
filename = "_".join(self.name.split()).lower()
self.filename = filename
self.dot = Digraph(self.name, filename=self.filename)
Expand Down
7 changes: 7 additions & 0 deletions tests/test_diagram.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,13 @@ def test_custom_filename(self):
Node("node1")
self.assertTrue(os.path.exists(f"{self.name}.png"))

def test_empty_name(self):
"""Check that providing an empty name don't crash, but save in a diagrams_image.xxx file."""
self.name = 'diagrams_image'
with Diagram(show=False):
Node("node1")
self.assertTrue(os.path.exists(f"{self.name}.png"))


class ClusterTest(unittest.TestCase):
def setUp(self):
Expand Down

0 comments on commit f260556

Please sign in to comment.