Resolve aliases in cost calculation #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caellian
changed the title
mckaygerhard
added a commit
to minenux/minetest-mod-moreblocks
that referenced
this pull request
Feb 19, 2022
* If stairs from stairs mod were crafted before moreblocks was enabled,
the old (now aliased) stairs variant is kept in inventory. If the player
tried to recycle that stair variant, `inv:contains_item("output", stackname)`
would return true as `contains_item` resolves alias names,
but `circular_saw:get_cost` would return nil as it's expecting exact
`stackname` matches which would later crash due to nil arithmetic.
This PR fixes this issue by resolving alias using `minetest.registered_aliases` table.
`circular_saw:get_cost` should work now in every scenario where
`inv:contains_item("output", stackname)` returns true.
* backported from minetest-mods#175
* fixes minetest-mods#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174.
If stairs from stairs mod were crafted before moreblocks was enabled, the old (now aliased) stairs variant is kept in inventory. If the player tried to recycle that stair variant,
inv:contains_item("output", stackname)would return true ascontains_itemresolves alias names, butcircular_saw:get_costwould return nil as it's expecting exactstacknamematches which would later crash due to nil arithmetic.This PR fixes this issue by resolving alias using
minetest.registered_aliasestable.circular_saw:get_costshould work now in every scenario whereinv:contains_item("output", stackname)returns true.