Realign the rail craft recipes #169
Conversation
|
Right, I was trying to mimick the previous changelog entries 8-) I'm actually having a bit of a second thought about this change. Since we're doing this “override productivity” for multiple things, I've been thinking that refactoring the code that I've now used for rails so that it can be used for all overrides would be nicer. I'll look into that. |
Oblomov
force-pushed
the
align-rail-craft
branch
from
4f78a97 to
8eeda7f
Compare
|
OK, refactored the whole “override production” thing, and ported all overloads to the new mechanism. |
redefinitions.lua
Outdated
| -- { detector, amount changing function } | ||
| -- { detector, amount changing function } | ||
| -- } | ||
| -- TODO consider exporting this function to other mods |
There was a problem hiding this comment.
| -- TODO consider exporting this function to other mods | |
| -- TODO: consider exporting this function to other mods |
There was a problem hiding this comment.
While we're at it, I could just do the export. Does moreblocks provide some kind of API object? Or should I just hook it into minetest directly?
There was a problem hiding this comment.
I guess we'll keep it as a TODO for now. Force-pushed with the colon.
In the next commits these will be used in place of the hardcoded overrides.
This replaces the override for the obsolete rail recipe with an override for the new recipes for all rail types. Fixes GitHub issue minetest-mods#162.
Oblomov
force-pushed
the
align-rail-craft
branch
from
9c94cc6 to
da04d2e
Compare
|
@Oblomov Is this good to merge now? 🙂 |
|
If you're happy with it, I'm happy with it. We can think about providing some kind of API at a later time, possibly with more stuff 8-) |
…ecoded * fixeds minetest-mods#162 * backported minetest-mods#169 * if 5+ engines are detected Use new function to override wall sign recipes * Introduce auxiliary functions to change craft amount even hardcoded overrides * but for 0.4.X let hardcoded cos older game engines does not change anymore * backported minetest-mods@ddf8b39
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This replaces the override for the obsolete rail recipe with an override
for the new recipes for all rail types. Rather than hard-coding the
recipes, we “reconstruct” the declared crafting recipes and simply pump
up the amount produced by 50% (which was the increase achieved over the
old recipe).
Fixes #162.