Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing terraform validate in pre-commit test #18

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

thenaturalist
Copy link
Contributor

This commit fixes a failure in terraform validate as it requires
the GITHUB_TOKEN to be present as of (at least) version 2.8.0.

This commit fixes a failure in terraform validate as it requires
the GITHUB_TOKEN to be present as of (at least) version 2.8.0.
Copy link
Member

@mariux mariux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@thenaturalist thenaturalist merged commit 747a30d into master Jun 29, 2020
@thenaturalist thenaturalist deleted the jan/fix-pre-commit-test branch June 29, 2020 19:41
@mariux
Copy link
Member

mariux commented Jun 30, 2020

I raised the issue upstream: https://github.com/terraform-providers/terraform-provider-github/issues/503
don't think we need further steps on our side as this is fixed now by providing the token.
It still breaks local pre-commits when no token is set, but it can be set to a random value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants