Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure qml files #48

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Restructure qml files #48

merged 1 commit into from
Dec 20, 2024

Conversation

devendrn
Copy link
Member

@devendrn devendrn commented Dec 6, 2024

This PR updates the names of qml files to be more consistent. Trying to follow a "Window > Screen > Section > Component" hierarchy.

The reasons for each change are mentioned below:

ThemedControls/*.qml -> Components/*.qml
The directory includes not just themed controls but also some custom components.

Launcher.qml -> MainNavigation.qml or could be MainLayout.qml
Main front page. Shows screen as well as navigation bar.

LauncherMain.qml -> HomeScreen.qml
MinecraftNews.qml -> NewsScreen.qml
Mods.qml -> ModsScreen.qml
GameLogWindow.qml -> GameLogScreen.qml
LauncherSettingsWindow.qml -> SettingsScreen.qml
Screens that come under MainNavigation

LauncherBase.qml -> BaseScreen.qml
LauncherLogin.qml -> LoginScreen.qml
LauncherUnsupported.qml -> UnsupportedScreen.qml
LauncherChangeLog.qml -> ChangelogScreen.qml
LauncherUnlock.qml -> UnlockScreen.qml
"Launcher" seems unnecessary. Use "Screen" instead to give better context.

GampadTool.qml -> GamepadTool.qml
Small typo

EditProfileWindow.qml -> ProfileEditPopup.qml
No longer a window.

LauncherSettingsGeneral.qml -> SettingsGeneralSection.qml
LauncherSettingsStorage.qml -> SettingsStorageSection.qml
LauncherSettingsVersions.qml -> SettingsVersionsSection.qml
LauncherSettingsDev.qml -> SettingsDevSection.qml
LauncherSettingsAbout.qml -> SettingsAboutSection.qml
Use "Section" to imply that it comes under a screen.

@ChristopherHX
Copy link
Member

Sorry I missed this, will send you an invite as well.

@ChristopherHX ChristopherHX merged commit c552659 into minecraft-linux:qt6 Dec 20, 2024
@ChristopherHX
Copy link
Member

Invite sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants