Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News improvement #42

Draft
wants to merge 1 commit into
base: qt6
Choose a base branch
from
Draft

Conversation

zzahkaboom24
Copy link
Contributor

@zzahkaboom24 zzahkaboom24 commented May 8, 2024

Improves the News section with proper articles, that match 1:1 the same with the original Minecraft Launcher.

Supports edition exclusion, but I havent implemented it yet, cuz I am still in talks (rather wanted to be) wether to add it or not.

Before:
image

After:
image

Improves the News section with proper articles, that match 1:1 the same with the original Minecraft Launcher.

Supports edition exclusion, but I havent implemented it yet, cuz I am still in talks wether to add it or not.
@zzahkaboom24
Copy link
Contributor Author

If that's okay, or there is anything to improve, you can let me know too

@ChristopherHX
Copy link
Member

I would rather add a checkbox like in the official launcher to change to this alternative url, because news like Hardcore Mode coming to bedrock are missing in your proposed feed. I don't want to open minecraft.net for seeing all of them

  • Minecraft.net News current
  • Minecraft Launcher News your proposal

Both news sources could pose a copyright issue per se

@zzahkaboom24 zzahkaboom24 marked this pull request as draft May 9, 2024 21:15
@zzahkaboom24
Copy link
Contributor Author

drafting to work on the potential changes

@devendrn
Copy link
Contributor

screenshot-24-05-10-05-29
Search and news content are just mockup. Load more articles is functional.

@zzahkaboom24
Copy link
Contributor Author

What I've been struggling with, and the main reason why I am drafting this in the first place, is that https://launchercontent.mojang.com/news.json is stuck on "Discover planet earth III DLC" from January 16th 2024. I dont know why it did not show me in the Minecraft Launcher the first time, but now it does. That tells me that they changed the link some time ago to something different and I have yet to find the new link containing the metadata of the Minecraft Launcher articles.

I already made a checkbox in the settings that changes between the default articles of this launcher and the ones from the minecraft launcher, but while working on the search bar and trying to match that with the Minecraft Launcher I started noticing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants