Allow compiler optimisations with -fno-delete-null-pointer-checks #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If at least -O1 is given then the client crashes on startup without disabling this optimisation. It is supported at least since GCC 3.4. This was a tricky one to find because -O0 works and -O1 doesn't but the GCC manual says this optimisation is only enabled at -O2. Turns out it is also enabled by default on most targets. It may be possible to narrow it down to a specific subproject or source file but applying it globally seems safest.
This was referenced Sep 3, 2019
Closed
|
I built mcpelauncher with this cxx flag, it is way faster! Hope it gets merged! |
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If at least
-O1is given then the client crashes on startup withoutdisabling this optimisation. It is supported at least since GCC 3.4.
This was a tricky one to find because
-O0works and-O1doesn't butthe GCC manual says this optimisation is only enabled at
-O2. Turnsout it is also enabled by default on most targets.
It may be possible to narrow it down to a specific subproject or
source file but applying it globally seems safest.