Fix for 1.19.60.26 Beta #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Congratulations to Mojang on successfully changing the signature of the Mouse::feed method! - If `_ZN5Mouse4feedEccssss` is not found, try to use `_ZN5Mouse4feedEcassss` instead
|
If I think more about it, they fixed the signature for arm based platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for changed ABI in 1.19.60.26 beta. Mojang just changed signature of
Mouse::feedfrom(char, char, short, short, short, short)to(char, signed char, short, short, short, short).Not tested on ARM platforms, macOS.
Code checks if
_ZN5Mouse4feedEccssssexists, if not, it tries to use the symbol_ZN5Mouse4feedEcassssinstead