Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for direct rule grant, add unit tests for same #5411

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

evankanderson
Copy link
Member

Summary

In #5385, I conflated the user_management and machine_accounts flags for enabling direct grants. Unfortunately, this was incorrect, and our smoke tests started to fail when I set the machine_account flag. This should allow re-enabling machine_accounts, while still having smoke tests pass.

Fixes #5145

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

In penance, I updated the AssignRole test to cover the new cases I'd introduced.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner February 8, 2025 16:44
@coveralls
Copy link

coveralls commented Feb 8, 2025

Coverage Status

coverage: 57.492% (+0.01%) from 57.481%
when pulling e9c04ca on evankanderson:fix-actions-smoke-testing
into 53e45ae on mindersec:main.

@evankanderson evankanderson force-pushed the fix-actions-smoke-testing branch from 2d6a037 to e9c04ca Compare February 8, 2025 23:14
@evankanderson evankanderson merged commit aae3ac4 into mindersec:main Feb 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish #4317 and merge
3 participants