Fix check for direct rule grant, add unit tests for same #5411
+99
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #5385, I conflated the
user_management
andmachine_accounts
flags for enabling direct grants. Unfortunately, this was incorrect, and our smoke tests started to fail when I set themachine_account
flag. This should allow re-enablingmachine_accounts
, while still having smoke tests pass.Fixes #5145
Change Type
Mark the type of change your PR introduces:
Testing
In penance, I updated the AssignRole test to cover the new cases I'd introduced.
Review Checklist: