Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trusty links updated #5407

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

davolokh
Copy link
Contributor

@davolokh davolokh commented Feb 5, 2025

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Links to Insight are updated and use utm_source param

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@davolokh davolokh requested a review from a team as a code owner February 5, 2025 15:37
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@@ -280,7 +280,7 @@ func (sph *summaryPrHandler) generateSummary() (string, error) {
constants.TrustyHttpURL,
"report",
strings.ToLower(alternative.Dependency.Ecosystem.AsString()),
url.PathEscape(alternative.Dependency.Name))
url.PathEscape(alternative.Dependency.Name) + "utm_source=minder")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a query parameter, not part of the path, right?

@davolokh davolokh force-pushed the fix/trusty-links-updated branch from 71bb55c to 35ce080 Compare February 6, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants