Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localhost detection for URL redirect protection #5293

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

evankanderson
Copy link
Member

Summary

It turns out that I was a bit too zealous on the redirect URL protection. Fixes https://github.com/mindersec/minder/pull/5282/files#r1913339896

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I read the code, sorry!

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner January 13, 2025 15:08
@evankanderson evankanderson merged commit ac4f2fc into mindersec:main Jan 13, 2025
25 checks passed
@coveralls
Copy link

Coverage Status

coverage: 56.611%. remained the same
when pulling 76f5016 on evankanderson:fix-redirect-protection
into 9b2ecaa on mindersec:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants