Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow path templating for pull request remediations #5216

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR enables path templating for pull request remediations.

So far this wasn't possible and it blocked the remediation type from being more versatile, whereas now this allows to set it based on the profile parameters (or of course hardcode it).

Related: https://github.com/stacklok/minder-stories/issues/129

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner December 17, 2024 13:09
@coveralls
Copy link

Coverage Status

coverage: 54.999% (-0.01%) from 55.009%
when pulling a99155e on enable-templating-path
into 9286b31 on main.

@rdimitrov rdimitrov merged commit 412dadb into main Dec 17, 2024
26 checks passed
@rdimitrov rdimitrov deleted the enable-templating-path branch December 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants