Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty version to be the same as v1 in providers #5172

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

evankanderson
Copy link
Member

Summary

While #5171 fixed auto-registration for new CLI clients, existing CLI clients and other users may still be broken by the validation we added. This provides a server-side fix which treats an unspecified version as "v1".

Fixes #5166

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I checked the swagger and generated code changes.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner December 10, 2024 21:18
@coveralls
Copy link

Coverage Status

coverage: 55.307% (+0.003%) from 55.304%
when pulling f0ec2ae on evankanderson:server-fix-auto-reg
into dc1d2ef on mindersec:main.

Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@JAORMX JAORMX merged commit 9336b1b into mindersec:main Dec 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto repo registration is not working
4 participants