Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow git ingester to work on Pull Requests as well #5170

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 10, 2024

Summary

This is useful for writing simple rules that check out the git repo for
a pull request.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is useful for writing simple rules that check out the git repo for
a pull request.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner December 10, 2024 09:40
@coveralls
Copy link

Coverage Status

coverage: 55.353% (-0.006%) from 55.359%
when pulling c245322 on JAORMX:pr-git
into 4e29d37 on mindersec:main.

Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice!

@JAORMX JAORMX merged commit a0d9e90 into mindersec:main Dec 10, 2024
26 checks passed
@JAORMX JAORMX deleted the pr-git branch December 10, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants