-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump components' versions in docker-compose.yaml #5152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @prezha!
There are some dependencies we're not ready to upgrade yet, but the rest looks good.
docker-compose.yaml
Outdated
@@ -125,7 +125,7 @@ services: | |||
|
|||
keycloak: | |||
container_name: keycloak_container | |||
image: quay.io/keycloak/keycloak:25.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not ready to upgrade Keycloak to v26 yet. We've been waiting for a compatible version of https://github.com/adorsys/keycloak-config-cli, which just came out. We'll be doing a careful upgrade in the coming days / weeks to ensure all the edge cases still work, since it is a major version update.
docker-compose.yaml
Outdated
@@ -145,7 +145,7 @@ services: | |||
|
|||
keycloak-config: | |||
container_name: keycloak_config | |||
image: bitnami/keycloak-config-cli:6.1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the comment above, we're going to plan this update later along with some thorough testing.
thanks for the review and providing some more context, @eleftherias ! based on that, i've reverted the change in keycloak-related dependencies and also bumped a notch up openfga - to be in line with the pr #5156 |
this is interesting:
|
Summary
Bump components for local development environment to current version in docker-compose.yaml:
keycloak to v26.0.7 (from: https://quay.io/repository/keycloak/keycloak?tab=tags)keycloak-config-cli to v6.2.1 (from: https://hub.docker.com/r/bitnami/keycloak-config-cli)01 (from: https://hub.docker.com/r/openfga/openfga)note re:keycloak: comment #5152 (review) below
Bonus: remove redundant entry in .gitignore.
Change Type
Mark the type of change your PR introduces:
Testing
Successfully tested locally:
Review Checklist: