Default project ID for data source create/update #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do some smart stuff in the middleware for the server to determine the target project in case the user does not specify it. We're not so smart ni persisting that to the create/update requests. This fixes that. Signed-off-by: Juan Antonio Osorio <[email protected]>
rdimitrov
previously approved these changes
Dec 3, 2024
Signed-off-by: Juan Antonio Osorio <[email protected]>
|
@rdimitrov had to fix the unit tests |
rdimitrov
approved these changes
Dec 3, 2024
|
Ah thanks for fixing this I was going to do it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We do some smart stuff in the middleware for the server to determine the
target project in case the user does not specify it. We're not so smart
in persisting that to the create/update requests. This fixes that; Making
creates/updates work without needing to explicitly specify a project ID.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: