Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make gen #3111

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix make gen #3111

merged 1 commit into from
Apr 16, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Apr 16, 2024

This was broken because I moved one of the interfaces listed in the makefile.

TODO: Use go generate annotations instead of listing the interfaces in the makefile.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This was broken because I moved one of the interfaces listed in the
makefile.

TODO: Use go generate annotations instead of listing the interfaces in
the makefile.
@dmjb dmjb requested a review from a team as a code owner April 16, 2024 09:34
@dmjb dmjb merged commit 1846b25 into main Apr 16, 2024
23 of 24 checks passed
@dmjb dmjb deleted the fix-gen-command branch April 16, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants