Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid condition in repo register #3076

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix invalid condition in repo register #3076

merged 1 commit into from
Apr 12, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Apr 12, 2024

Summary

This removes the invalid logic in the repo register subcommand which accidentally thought all repos were already registered in minder.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner April 12, 2024 14:23
@coveralls
Copy link

Coverage Status

coverage: 47.988%. remained the same
when pulling d365831 on fix-repo-reg
into fd7be78 on main.

@JAORMX JAORMX merged commit 3ac0a51 into main Apr 12, 2024
21 checks passed
@JAORMX JAORMX deleted the fix-repo-reg branch April 12, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants