Add ProviderID field to EntityInfoWrapper #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #3071 This PR adds the ProviderID field to the event structure, and changes the executor to use the ProviderID if present. Note that the ProviderID is not actually set anywhere at this point: I am doing this changeover in phases to avoid backwards compatibility issues as we change the event structure.
dmjb
force-pushed
the
add-provider-id-eiw
branch
from
427ec67 to
f401089
Compare
evankanderson
approved these changes
Apr 15, 2024
Comment on lines
+205
to
+209
| if inf.ProviderID == uuid.Nil { | ||
| provider, err = e.providerStore.GetByName(ctx, inf.ProjectID, inf.Provider) | ||
| } else { | ||
| provider, err = e.providerStore.GetByID(ctx, inf.ProviderID) | ||
| } |
There was a problem hiding this comment.
Slight preference to reverse the order of these conditions, since we want to prefer the inf.ProviderID not being nil.
There was a problem hiding this comment.
I will do this in the next PR where the ProviderID is actually set. Right now, since it's not being set, the current order makes more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3071
This PR adds the ProviderID field to the event structure, and changes the executor to use the ProviderID if present. Note that the ProviderID is not actually set anywhere at this point: I am doing this changeover in phases to avoid backwards compatibility issues as we change the event structure.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: