Fix for #309 #310
Merged
Fix for #309 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| system code | ||
| $?.to_i | ||
| Kernel.system code | ||
| $?.exitstatus |
There was a problem hiding this comment.
Here $? is a Process::Status instance that represents a 16-bit integer that ruby got from the system. Process::Status#to_i returns the whole 16-bit integer and has no meaning by itself. It coincidently is 0 when the command exits with status 0, but when it exits with anything else, it's not usable, so I changed it to use Process::Status#exitstatus which returns the least significant 8-bits, which is the process exit status.
d4be4st
added a commit
that referenced
this pull request
Jul 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this PR tries to solve is better explained in #309.
Feedback is appreciated, specially regarding tests. I didn't test
Mina::LocalHelpers#localbecause I didn't know how to setup the rake scope accordingly. Also I didn't test the return value whenterm_mode == :execbecause, well...Kernel.execdoesn't return.