Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #9. MAX_PAYLOAD warning #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions target/min.c
Original file line number Diff line number Diff line change
Expand Up @@ -503,14 +503,15 @@ static void rx_byte(struct min_context *self, uint8_t byte)
self->rx_control = byte;
crc32_step(&self->rx_checksum, byte);
if (self->rx_frame_length > 0) {
self->rx_frame_state = RECEIVING_PAYLOAD;
#if (MAX_PAYLOAD != 255)
// Can reduce the RAM size by compiling limits to frame sizes
if (self->rx_frame_length <= MAX_PAYLOAD) {
self->rx_frame_state = RECEIVING_PAYLOAD;
} else {
if (self->rx_frame_length > MAX_PAYLOAD) {
// Frame dropped because it's longer than any frame we can buffer
min_debug_print("Dropping frame because length %d > MAX_PAYLOAD %d", self->rx_frame_length, MAX_PAYLOAD);
self->rx_frame_state = SEARCHING_FOR_SOF;
}
#endif
} else {
self->rx_frame_state = RECEIVING_CHECKSUM_3;
}
Expand Down