Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some union splitting in time array clients #921

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

davidanthoff
Copy link
Collaborator

Fixes more performance regressions on Julia 1.7 and 1.8.

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #921 (55f0e13) into master (5734b0e) will decrease coverage by 0.00%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   83.32%   83.31%   -0.01%     
==========================================
  Files          39       39              
  Lines        4005     4009       +4     
==========================================
+ Hits         3337     3340       +3     
- Misses        668      669       +1     
Flag Coverage Δ
unittests 83.31% <84.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/time_arrays.jl 91.64% <84.61%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lrennels
Copy link
Collaborator

@davidanthoff looks good to merge

@davidanthoff davidanthoff merged commit 9892def into master Sep 17, 2022
@davidanthoff davidanthoff deleted the remove-union-split branch September 17, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants